👍 This looks good.

I don't think this is captured in the style guide, and it should be.

BTW, new pages need to be added to src/SUMMARY.md.

I was wondering about the rustfmt changes and whether or not they all need to be on separate pages. I'm unclear about how many changes (from the list) will end up in the edition. If individual changes don't have significant text associated with them, I was wondering if putting them on the same page might make sense (especially if the Migration section is identical for each one).

However, if a single page ends up being really long, then that probably wouldn't be good.

Not something we need to decide right now, but would be good to think about.

Yes, I had similar thoughts in both directions, as you described, and ended up suggesting just doing one per page to @calebcartwright. That makes it a bit easier to follow the flow and template of the other pages, allows us to merge these individually without conflicts, etc. We can always merge them into one page later if we find it better editorially.

Agreed. I'll continue filing these as individual pages but I think most of them would be best merged into one (otherwise I could see a disproportionately high ratio of text in the edition guide doc being "run cargo fmt" repeated ad nauseam)

At this point I'm not entirely decided on which ones I think would be best combined on one page, but I'm leaning towards following the model we did for the Style Guide changelog where we had a single entry for "misc rustfmt fixes", which includes this raw ident sorting item.

If it doesn't add any harm/complexity for those of you driving the edition work, perhaps we could just leave these rustfmt PRs open here so that t-style/t-rustfmt can provide input on the text, and then I'll copy pasta things around (with relevant SUMMARY.md entries) and close some of the PRs once we figure out how to structure the full set?

Seems fine to me!